Implement disable ignores, a flag which disables all type ignores#19939
Draft
wyattscarpenter wants to merge 4 commits intopython:masterfrom
Draft
Implement disable ignores, a flag which disables all type ignores#19939wyattscarpenter wants to merge 4 commits intopython:masterfrom
wyattscarpenter wants to merge 4 commits intopython:masterfrom
Conversation
This is available as a command-line flag and a global configuration option. This commit also includes documentation and tests for this feature. Fixes python#13201
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Why do my two tests now fail, but only for the two "Parallel tests with py314-ubuntu" checks? (Not even including parallel tests with windows.) Random luck relating to some known flakiness (that I haven't heard of)? Do I not understand something? Should this be listed in OPTIONS_AFFECTING_CACHE or something? |
This comment has been minimized.
This comment has been minimized.
…blem I'm just guessing that this might be why my two tests fail, but only for the two 'Parallel tests with py314-ubuntu' checks. (Not even including parallel tests with windows.) since this isn't a per-module option, we add it to the list that isn't that
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
Author
|
Well, as I have no further ideas as to what is wrong, I guess I'll just draft this PR for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is available as a command-line flag and a global configuration option. This commit also includes documentation and tests for this feature. Fixes #13201